cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: removed unused HypervDummyResourceBase cl...
Date Fri, 11 Mar 2016 13:48:47 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1437#issuecomment-195369454
  
    @eriweb I saw the Jenkins build, and it was ok, that meant the code compiled and all of
the tests cases (unit and integration tests) were executed properly.
    
    I noticed that the functional tests with Marvin were not executed (there is  not CI in
place right now), but I did not find them needed for this kind of contribution.
    
    Additionally, I know that mistakes can happen if the code is not properly tested and reviewed.
I just said that it did not need functional testing after getting the code, and  carefully
checking it myself; that is how I found the only reference to that class in a log message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message