cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ustcweizhou <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x
Date Mon, 07 Mar 2016 22:45:07 GMT
Github user ustcweizhou commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1430#discussion_r55286730
  
    --- Diff: agent/src/com/cloud/agent/Agent.java ---
    @@ -412,7 +412,8 @@ protected void reconnect(final Link link) {
                 try {
                     _connection.start();
                 } catch (final NioConnectionException e) {
    -                throw new CloudRuntimeException("Unable to start the connection!", e);
    +               s_logger.info("Attempted to connect to the server, but received an unexpected
exception, trying again...");
    --- End diff --
    
    1. I think you should fix line 230/238, that's the root cause of the issue. line 415 is
not.
    2. line 416 can be removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message