cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GabrielBrascher <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...
Date Mon, 07 Mar 2016 01:08:43 GMT
Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1417#discussion_r55153415
  
    --- Diff: test/integration/component/test_deploy_vm_from_snapshot.py ---
    @@ -0,0 +1,644 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +
    +# Import Local Modules
    +from marvin.codes import FAILED, PASS
    +from nose.plugins.attrib import attr
    +from marvin.cloudstackTestCase import cloudstackTestCase
    +from marvin.cloudstackAPI import seedTemplateFromVmSnapshot
    +from marvin.lib.utils import cleanup_resources, validateList
    +from marvin.lib.base import (Account,
    +                             DiskOffering,
    +                             ServiceOffering,
    +                             VirtualMachine,
    +                             VmSnapshot,
    +                             Volume)
    +from marvin.lib.common import (get_zone,
    +                               get_domain,
    +                               get_template)
    +import urllib
    +import tempfile
    +import os
    +import time
    +from functools import reduce
    +
    +
    +class TestDeployVm(cloudstackTestCase):
    +
    +    @classmethod
    +    def setUpClass(cls):
    +        testClient = super(TestDeployVm, cls).getClsTestClient()
    +        cls.apiclient = testClient.getApiClient()
    +        cls._cleanup = []
    +        cls.unsupportedHypervisor = False
    +        cls.hypervisor = testClient.getHypervisorInfo()
    +        if not cls.hypervisor.lower() in "vmware":
    +            cls.unsupportedHypervisor = True
    +            return
    +
    +        cls.services = testClient.getParsedTestDataConfig()
    +        # Get Zone, Domain and templates
    +        cls.domain = get_domain(cls.apiclient)
    +        cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
    +
    +        template = get_template(
    --- End diff --
    
    Shouldn't be `cls.template` here also? (ExtractVolumeFromVmSnapshot class uses cls.template).
    Also I am with @sanju1010 about some redundant code. Both classes ExtractVolumeFromVmSnapshot
and TestDeployVm have duplicated code, could you please create a more generic class to implement
some of the duplicated code?
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message