cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9298: Improve performance of r...
Date Thu, 03 Mar 2016 23:53:09 GMT
Github user rafaelweingartner commented on a diff in the pull request:
    --- Diff: server/test/com/cloud/api/query/dao/
    @@ -0,0 +1,59 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +import static org.junit.Assert.assertEquals;
    +import org.apache.cloudstack.api.BaseResponseWithTagInformation;
    +import org.apache.cloudstack.api.response.ResourceTagResponse;
    +import org.powermock.api.mockito.PowerMockito;
    +public abstract class GenericDaoBaseWithTagInformationBaseTest<T extends BaseViewWithTagInformationVO,
    +                                                                ID extends Serializable,
    +                                                                Z extends BaseResponseWithTagInformation>
    +    public void prepareSetup(String tagKey, String tagValue){
    +        PowerMockito.spy(ApiDBUtils.class);
    +        PowerMockito.stub(PowerMockito.method(ApiDBUtils.class, "newResourceTagResponse")).toReturn(getResourceTagResponse(tagKey,
    +    }
    +    private ResourceTagResponse getResourceTagResponse(String tagKey, String tagValue){
    +        ResourceTagResponse tagResponse = new ResourceTagResponse();
    +        tagResponse.setKey(tagKey);
    +        tagResponse.setValue(tagValue);
    +        return tagResponse;
    +    }
    +    public void testUpdateTagInformation(GenericDaoBaseWithTagInformation<T, ID, Z>
dao, T baseView, Z baseResponse,
    --- End diff --
    What about checking every property that the method "updateTagInformation" touches?
    Additionally, to test that, you do not need to pass as parameter "tagId, key and others"
to set at the baseView. If you always use the same values (I see no problem on that), no need
to receive those parameters.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message