cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9298: Improve performance of r...
Date Tue, 01 Mar 2016 23:26:44 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1425#issuecomment-190961759
  
    @nvazquez and @pedro-martins, 
    I am ok with the code now, expect the constructor bit.
    The question you should ask about the constructor is, is it used NOW? If not, why create
it. In the future when the need appear, we can create it; this way we can avoid unused code
that may be left aside and never used.
    
    Additionally, I am with @pedro-martins, if you like, tests cases would be pretty welcome
here.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message