cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pedro-martins <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...
Date Tue, 01 Mar 2016 16:41:49 GMT
Github user pedro-martins commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1424#discussion_r54595010
  
    --- Diff: server/src/com/cloud/template/TemplateManagerImpl.java ---
    @@ -275,6 +277,8 @@
         private StorageCacheManager cacheMgr;
         @Inject
         private EndPointSelector selector;
    +    @Inject
    +    private ImageStoreDao _imgStoreDao;
    --- End diff --
    
    hi @syed,
    could you remove the "_" character from the variable name? the underscore is usually used
in c++ programs to name private variables but it is not a convention in Java.
    Ty.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message