Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
Subject: Re: [Proposal] Concerning open PRs
From: sebgoa <runseb@gmail.com>
In-Reply-To: <191A086B-88ED-42CE-958C-B3EBD1BF0D39@schubergphilis.com>
Date: Thu, 18 Feb 2016 09:36:50 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <BA326EEA-10E5-4EDE-848D-409B582F331C@gmail.com>
References: <191A086B-88ED-42CE-958C-B3EBD1BF0D39@schubergphilis.com>
To: dev@cloudstack.apache.org


> On Feb 18, 2016, at 8:38 AM, Wilder Rodrigues =
<WRodrigues@schubergphilis.com> wrote:
>=20
> Hi all,
>=20
>=20
> It=E2=80=99s been a long time, but the Wolverine is not dead yet. ;)
>=20
> Currently we have 175 opened PRs, which we all agree to be a lot, =
given the fact that few people, if any, are testing/merging them. I have =
been a bit off the radar, but from next week I will start helping to get =
some of those PRs tested and, hopefully, merged.
>=20
> In order to get the community working as an unit, I would like to =
propose the following:
>=20
> * One should only create a PR after testing an existing PR.
>  - By testing I mean=E2=80=A6 testing. Not just looking into it and =
saying =E2=80=9CLGTM=E2=80=9D. Manual tests should also count, with =
screenshots attached to the PR.
>=20
> That will make those with test environment pitch in and help, and in =
addition might also decrease the frenzy for creating PRs which =
occasionally won=E2=80=99t be tested within a month time - or longer.
>=20
> For others not creating PRs that often, like me, we should help =
testing at least 1 PR per week.
>=20
> Being a bit more blunt now, if a PR is created but the person does not =
contribute with testing an existing one, the new PR should be closed.
>=20
> What do you think?
>=20

That sounds too extreme to my taste.

Bottom line, folks who submit PR need to stay on top of them and address =
comments.

But then we need to have that CI in place

-sebastien

> Cheers,
> Wilder