Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: DaanHoogland <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1421-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1421-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: zip the processed json files so we
 save d...
Content-Type: text/plain
Message-Id: <20160220192345.9938CE0104@git1-us-west.apache.org>
Date: Sat, 20 Feb 2016 19:23:45 +0000 (UTC)

Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1421#discussion_r53555684
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py ---
    @@ -272,5 +275,10 @@ def setPath(self, path):
         def __moveFile(self, origPath, path):
             if not os.path.exists(path):
                 os.makedirs(path)
    -        timestamp = str(int(round(time.time())))
    -        os.rename(origPath, path + "/" + self.fileName + "." + timestamp)
    +
    +        zipped_file_name = path + "/" + self.fileName + "." + str(uuid.uuid4()) + ".gz"
    --- End diff --
    
    would it make sense to have the timestamp in the filename as well? for easy ordering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---