cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sanjeev N <sanj...@apache.org>
Subject Re: [GitHub] cloudstack pull request: Squashing two commits in to single commit
Date Mon, 15 Feb 2016 06:12:36 GMT
Is it okay to merge this PR or we need to wait for two LGTMs, since
original PR 667 already has two LGTMs ?

On Fri, Feb 12, 2016 at 1:59 PM, remibergsma <git@git.apache.org> wrote:

> Github user remibergsma commented on the pull request:
>
>     https://github.com/apache/cloudstack/pull/1411#issuecomment-183226537
>
>     Thanks! LGTM, based on #667.
>
>     I'd suggest though to make the commit message and PR title more
> descriptive.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message