cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GabrielBrascher <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9261: Query to traffic sentine...
Date Sun, 28 Feb 2016 20:29:40 GMT
Github user GabrielBrascher commented on the pull request:

    https://github.com/apache/cloudstack/pull/1418#issuecomment-189941771
  
    @kansal Could you please consider the following adjustments?
    - create a method for the "Part 1" (lines 213-219). With the command as parameter and
returning the connection to be used for "Part 2" (lines 221-223);
    - create a method for "Part 2", returning the output stream and receiving as parameter
the connection and post data.
    
    I think that with these two methods, the code would be more readable.
    
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message