cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maneesha-p <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8830 CLONE - VM snapshot fails...
Date Wed, 24 Feb 2016 12:40:57 GMT
Github user maneesha-p commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/798#discussion_r53932297
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
    @@ -1464,4 +1440,45 @@ private String deleteDir(String dir) {
         private static String getVolumeRelativeDirInSecStroage(long volumeId) {
             return "volumes/" + volumeId;
         }
    +
    +    /**
    +     * This method is to check if a given TaskInfo Object is valid( and has name and
entity name assigned).It return true if TaskInfo Object is valid and false otherwise.
    +     *
    +     * @param TaskInfo
    +     *        info
    +     * @return boolean(true or false)
    +     **/
    +    private boolean isvalidTaskInfoObj(TaskInfo info){
    +        return !(info == null || info.getEntityName() == null || info.getName() == null);
    +    }
    +
    +    private boolean waitForRunningTaskOnVM(String vmName, String taskName, VmwareContext
context) throws Exception {
    --- End diff --
    
    @rodrigo93 It returns the same value as method 'waitForTask' .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message