cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alexandrelimassantana <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8865: Adding SR doesn't create...
Date Sun, 21 Feb 2016 18:21:01 GMT
Github user alexandrelimassantana commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/876#discussion_r53570532
  
    --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
    @@ -2378,6 +2378,23 @@ public boolean maintenanceFailed(final long hostId) {
         }
     
         @Override
    +    public List<HostVO> listAllUpHosts(Type type, Long clusterId, Long podId, long
dcId) {
    --- End diff --
    
    Hi @SudharmaJain
    
    could you also write an unit test for this new method you created since it brings new
functionalities to the code?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message