cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GabrielBrascher <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9280: Allow system VM volumes ...
Date Wed, 17 Feb 2016 11:08:46 GMT
Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1406#discussion_r53149620
  
    --- Diff: engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java
---
    @@ -92,7 +92,7 @@ public static VolumeObject getVolumeObject(DataStore dataStore, VolumeVO
volumeV
         public String getAttachedVmName() {
             Long vmId = volumeVO.getInstanceId();
             if (vmId != null) {
    -            VMInstanceVO vm = vmInstanceDao.findById(vmId);
    +            VMInstanceVO vm = vmInstanceDao.findByIdIncludingRemoved(vmId);
    --- End diff --
    
    @ProjectMoon I couldn't find the "findByIdIncludingRemoved" method 
    (https://github.com/apache/cloudstack/blob/master/engine/schema/src/com/cloud/vm/dao/VMInstanceDao.java).
    
    Am I missing something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message