cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mike-tutkowski <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...
Date Tue, 16 Feb 2016 18:23:48 GMT
Github user mike-tutkowski commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1403#discussion_r53053848
  
    --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
    @@ -172,6 +195,12 @@ private void validate(SnapshotInfo snapshotInfo) {
             }
         }
     
    +    private boolean usingBackendSnapshotFor(SnapshotInfo snapshotInfo) {
    +        String property = getProperty(snapshotInfo.getId(), "takeSnapshot");
    +
    +        return Boolean.parseBoolean(property);
    +    }
    +
         private Void handleCreateTemplateFromSnapshot(SnapshotInfo snapshotInfo, TemplateInfo
templateInfo, AsyncCompletionCallback<CopyCommandResult> callback) {
    --- End diff --
    
    I believe our current best practice is to not squash commits (i.e. to preserve the history).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message