cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cristofolini <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.5] vmware: improve support for disk co...
Date Sun, 14 Feb 2016 20:33:36 GMT
Github user cristofolini commented on the pull request:

    https://github.com/apache/cloudstack/pull/1366#issuecomment-183970215
  
    @bhaisaab Did you get to see the output of the jenkins build? Was it just another false
positive? I don't see anything in the code that could cause it to fail...
    
    But, if I may make a small suggestion, I'd ask you to extract the contents from that if
statement beginning at line 1799 to its own method, just to help out with readability, as
the sheer amount of conditionals involved in the original method can make it a bit overwhelming
to read. :) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message