cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9283: add pid to java argument...
Date Thu, 11 Feb 2016 00:49:01 GMT
Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1409#discussion_r52551673
  
    --- Diff: packaging/systemd/cloudstack-usage.service ---
    @@ -27,10 +27,11 @@ Environment=JAVA_HOME=/usr/lib/jvm/jre
     Environment=JAVA_HEAP_INITIAL=256m
     Environment=JAVA_HEAP_MAX=2048m
     Environment=JAVA_CLASS=com.cloud.usage.UsageServer
    +Environment=JAVA_PID=$$
     ExecStart=/bin/sh -ec '\
         export UCP=`ls /usr/share/cloudstack-usage/cloud-usage-*.jar /usr/share/cloudstack-usage/lib/*.jar
| tr "\\n" ":"`; \
         export CLASSPATH="$UCP:/etc/cloudstack/usage:/usr/share/java/mysql-connector-java.jar";
\
    -    ${JAVA_HOME}/bin/java -Xms${JAVA_HEAP_INITIAL} -Xmx${JAVA_HEAP_MAX} -cp "$CLASSPATH"
$JAVA_CLASS'
    +    ${JAVA_HOME}/bin/java -Dpid=${JAVA_PID} -Xms${JAVA_HEAP_INITIAL} -Xmx${JAVA_HEAP_MAX}
-cp "$CLASSPATH" $JAVA_CLASS'
    --- End diff --
    
    LGTM (did not test by creating packages and installing it though)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message