cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...
Date Tue, 09 Feb 2016 11:14:03 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1361#issuecomment-181819761
  
    @nvazquez, luckily the Jenkins build finished with success now.
    
    @kishankavala, for now, I believe the simplest solution is the better. When more details
are necessary, we change the code to send a map or some other structure, I personally do not
like using maps to move data around, I prefer simple and descriptive POJOs.
    
    Additionally, the task to move getters and setters to an upper class is not easily achievable.
I thought about that a while, and after inspecting the command classes that would have to
be changed, I decided to mark that as a future work; of course, if you have an easy, nice
and neat solution, you are welcome to share. @nvazquez had around worked around a lot of problems
and had written a pretty nice, well documented and tested code.
    
    @nvazquez, after all emails and messages exchanged, I can give an LGTM to this PR. Great
job man ;)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message