cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kishankavala <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...
Date Tue, 09 Feb 2016 05:21:13 GMT
Github user kishankavala commented on the pull request:

    https://github.com/apache/cloudstack/pull/1361#issuecomment-181715514
  
    @nvazquez
    Apologies for reviewing it late.
    1. Since version is fetched from image_store_details, can we send a map with all details
for the image_store instead of just the version. This will make the approach more generic.
In case more info is required for other vendors in future, too many changes can be avoided

    2.  Nfsversion param and corresponding getter/setter methods can be moved to a base class
(something like BaseImageStoreCommand)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message