cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GabrielBrascher <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...
Date Sun, 07 Feb 2016 00:51:45 GMT
Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/846#discussion_r52110260
  
    --- Diff: server/src/com/cloud/network/ExternalDeviceUsageManagerImpl.java ---
    @@ -342,6 +342,12 @@ public ExternalDeviceNetworkUsageTask() {
     
             @Override
             protected void runInContext() {
    +            //Check if there are any external deivces
    +            //Skip external device usage collection if none exist
    --- End diff --
    
    @kishankavala Could you please change from "deivces" to "devices"?
    
    Also, you can use this commented lines as a Javadoc block describing the runInContext()
method (if you think it would improve your code).
    
    Except that typo, your code seems ok.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message