cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Check the existence of 'forceencap' param...
Date Sat, 06 Feb 2016 13:33:58 GMT
Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1402#discussion_r52102132
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
    @@ -531,6 +531,8 @@ def configure_ipsec(self, obj):
             file.addeq(" pfs=%s" % CsHelper.bool_to_yn(obj['dpd']))
             file.addeq(" keyingtries=2")
             file.addeq(" auto=start")
    +        if not obj.has_key('encap'):
    --- End diff --
    
    Consider using: if 'encap' not in obj, instead of has_key(). More pythonic that way ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message