cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GabrielBrascher <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...
Date Sat, 06 Feb 2016 01:53:08 GMT
Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1357#discussion_r52095108
  
    --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java ---
    @@ -4932,6 +4932,32 @@ public Domain getVlanDomain(long vlanId) {
             return _networkOfferingDao.search(sc, searchFilter);
         }
     
    +     @Override
    +     @DB
    +     public boolean releaseDomainSpecificVirtualRanges(final long domainId) {
    +        final List<DomainVlanMapVO> maps = _domainVlanMapDao.listDomainVlanMapsByDomain(domainId);
    +        if (maps != null && !maps.isEmpty()) {
    --- End diff --
    
    @ustcweizhou For a List you can use CollectionUtils.isEmpty (https://commons.apache.org/proper/commons-collections/apidocs/org/apache/commons/collections4/CollectionUtils.html#isEmpty%28java.util.Collection%29)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message