cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rodrigo93 <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...
Date Sat, 06 Feb 2016 01:22:30 GMT
Github user rodrigo93 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/837#discussion_r52094072
  
    --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
    @@ -1148,15 +1148,16 @@ public Host cancelMaintenance(final CancelMaintenanceCmd cmd)
{
         }
     
         @Override
    -    public Host reconnectHost(final ReconnectHostCmd cmd) {
    -        final Long hostId = cmd.getId();
    +    public Host reconnectHost(ReconnectHostCmd cmd) throws CloudRuntimeException, AgentUnavailableException{
    --- End diff --
    
    Does this method need to return a host? It seems that it just reconnects to a host, if
not, throws an exception.
    If so, it could be void as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message