cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jayapalu <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Strongswan vpn feature
Date Fri, 05 Feb 2016 10:51:56 GMT
Github user jayapalu commented on the pull request:

    https://github.com/apache/cloudstack/pull/872#issuecomment-180292881
  
    @remibergsma @bhaisaab 
    I have seen observed the your cloud monkey tests, some thing wrong createvpnconnection
steps.
    create-vpns.sh is not passing the 'passive' argument for one of the api.
    I have updated your script create_vpns.sh copying at the end. With that it is works fine.
    
    If the connection is in error state checks2svpnconnection command is ignoring the error
state connection. That is the reason its status is not updated.
    
    Steps:
    1. create first vpn connection with passive=true. This creates the vpn config in VR but
it does not initiate the connection
    2. Create the second vpn connection with 'passive=false'. This creates the vpn config
and initiate the vpn connection.
    This way first vpn connection will not go error state. If the first vpn connection is
called with 'passive=False' it try to bring the up connection it will fail because there is
no other end.
    
    Please give the LGTM after running the tests. It is long pending PR.
    
    "
    cat create-vpns.sh
    #!/bin/bash
    #
    #
    #
    vpncustgws=`cloudmonkey list vpncustomergateways | grep ^id | awk ' { print $3 }'`
    vpngws=`cloudmonkey list vpngateways | grep ^id | awk ' { print $3 }'`
    passive=true;
    for vpngw in $vpngws
    do
       pubip=`cloudmonkey list vpngateways id=$vpngw | grep ^publicip | awk '{print $3}'`
       echo "dealing with $vpngw, $pubip"
       for vpncustgw in $vpncustgws
       do
           custgw=`cloudmonkey list vpncustomergateways id=$vpncustgw | grep ^gateway | awk
'{print $3}'`
           if [ $custgw == $pubip ]
           then
               echo "$pubip is me, $vpncustgw, $custgw, $vpngw!"
           else
               echo "creating vpn: $custgw, $pubip"
               cloudmonkey create vpnconnection s2scustomergatewayid=$vpncustgw s2svpngatewayid=$vpngw
$passive
    	   passive=false
           fi
       done
    done"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message