cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GabrielBrascher <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.7] vmware: improve support for disks
Date Wed, 03 Feb 2016 13:09:29 GMT
Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1365#discussion_r51717944
  
    --- Diff: core/src/org/apache/cloudstack/storage/command/AttachAnswer.java ---
    @@ -34,6 +37,12 @@ public AttachAnswer(DiskTO disk) {
             setDisk(disk);
         }
     
    +    public AttachAnswer(DiskTO disk, Map<String, String> diskDetails) {
    --- End diff --
    
    @bhaisaab Thanks for fixing the access level. The code seems ok, just one more question.
    
    Sorry to ask you now, I should have seen this before. Is this constructor used (**AttachAnswer(DiskTO
disk, Map<String, String> diskDetails)**)?
    
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message