Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 884F818073 for ; Wed, 20 Jan 2016 05:57:57 +0000 (UTC) Received: (qmail 57951 invoked by uid 500); 20 Jan 2016 05:57:57 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 57889 invoked by uid 500); 20 Jan 2016 05:57:57 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 57877 invoked by uid 99); 20 Jan 2016 05:57:56 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jan 2016 05:57:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 52A84C35B3 for ; Wed, 20 Jan 2016 05:39:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.88 X-Spam-Level: ** X-Spam-Status: No, score=2.88 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=solidfire.com Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ETIF-attc5z4 for ; Wed, 20 Jan 2016 05:38:58 +0000 (UTC) Received: from mail-yk0-f173.google.com (mail-yk0-f173.google.com [209.85.160.173]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id 995E02139D for ; Wed, 20 Jan 2016 05:38:58 +0000 (UTC) Received: by mail-yk0-f173.google.com with SMTP id a85so597059897ykb.1 for ; Tue, 19 Jan 2016 21:38:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=solidfire.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=GYqTFLc9Yn9UgQ4Q1eCX9XE0qRELyae7yaPYZbirrOI=; b=LoSxBUFUPtU3K3pErjsQt6bu3zEZXlW7lSxhB0rUguqjgX9qMoRouWPmX3dH7GykL/ Cpi9RAN6glVtpVd7yS2vqULsf7+vro5U6RC3qymWrS7fEeI0N3l3kt9+/rllPWHAe8kS /0Lbl0CcIjXYrrFeNL4VFJ0VfPIK/FNdjU4ME= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=GYqTFLc9Yn9UgQ4Q1eCX9XE0qRELyae7yaPYZbirrOI=; b=CamVr3vu+Y8gmRxKNq0eH6XiiEZ5be3NEQn915OM2gFAf06Gi8K8HY9RJjZyHSU/WG dnOe2wwG1UHJSYPyr2xCeFD9DFV76EpoqaAzclcUOO9Rh28TjdJhMYNTltFAhrwme8dg 286pnV9jTFa12wb+/Ih+bwSrGS+WTg4S/JIssurg4OlxKN1OKsYoGzclQnWl4xjNjUnB 3kkXWXjUtamdl5FpkM1j3BKnercr3IHlTVK8Rd3hARqrq6XBPOPbHPKOFf/Aw6rof8Or RIw9MayNGRN8wfUQ3PYNp4UrM0JygEGuQ6AkW7YxMCZ1HA6RCtfykhQB6WqjZIL3ahhx XnHA== X-Gm-Message-State: ALoCoQmCRvM/a3SW5Jt8yEwpcDl9eRt1J8MZIE0MjV0S5xeleq+vAYEWIErEF3XoYFBxLTS61FtfVpyVFgxuiez2cl45YsZAxBuKVUJRq3HAJi5n7SVVr3M= X-Received: by 10.37.100.70 with SMTP id y67mr10108169ybb.25.1453268332027; Tue, 19 Jan 2016 21:38:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.118.75 with HTTP; Tue, 19 Jan 2016 21:38:12 -0800 (PST) In-Reply-To: References: From: Mike Tutkowski Date: Tue, 19 Jan 2016 22:38:12 -0700 Message-ID: Subject: Re: Help with JUnits To: "dev@cloudstack.apache.org" Content-Type: multipart/alternative; boundary=001a1142f626b1dc220529bd6647 --001a1142f626b1dc220529bd6647 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I'm not sure what CloudStack's test-coverage numbers look like (for either unit or integration), but I suspect we are quite well below 100% coverage. On Tue, Jan 19, 2016 at 10:34 PM, B Prakash wrote: > Yes it does, thanks. Next I am going through the code to identify a > pattern (like class name ending with TEST :-)) to identify junit code. = I > am unable to zero in on few of the operations ie I am unable to find unit > test for this operation UserVmManagerImpl.commitUserVm. I am still > looking for it. Is the Junit coverage 100%? > > ________________________________________ > From: Mike Tutkowski > Sent: Tuesday, January 19, 2016 3:01 AM > To: dev@cloudstack.apache.org > Subject: Re: Help with JUnits > > So, yeah, unit tests are written in Java while integration tests are > written in Python using Marvin...if that helps clarify things a bit more. > > On Tue, Jan 19, 2016 at 12:45 AM, B Prakash wrote: > > > Thanks Mike, I read through the link and also saw the video, this answe= rs > > part of my question about executing the unit tests. The other part of > the > > questions still remains ie were are junits written in Java for this cla= ss > > and operation UserVmManagerImpl.commitUserVm. > > > > How do we check the junit coverage for a particular class and > > implementation in it? Where do I start looking for them and confirm if > > they exist? > > > > ________________________________________ > > From: Mike Tutkowski > > Sent: Monday, January 18, 2016 11:51 PM > > To: dev@cloudstack.apache.org > > Subject: Re: Help with JUnits > > > > Here's a video of a presentation I gave about Marvin (from CloudStack > Days > > in Austin last year): > > > > https://www.youtube.com/watch?v=3DN_eKBA_TeOs > > > > On Mon, Jan 18, 2016 at 9:49 PM, Mike Tutkowski < > > mike.tutkowski@solidfire.com> wrote: > > > > > Does this help? > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Marvin+-+Testing+w= ith+Python > > > > > > On Mon, Jan 18, 2016 at 8:56 PM, B Prakash wrote= : > > > > > >> Hi, > > >> > > >> > > >> Please can someone help me with identifying and amending junits > for > > >> UserVmManagerImpl.commitUserVm? I see a test class called > > >> UserVmManagerTest but I dont see a good junits coverage here. Also > > link in > > >> the 'Developer > Testing > Unit testing with JUnit and Spring' doesn= t > > give > > >> out lot of details on junits. > > >> > > >> 1. Am I looking at the right place for junits for the class > > >> UserVmManagerImpl.commitUserVm? > > >> 2. Is there any other link that provides more details on JUnits? > > >> 3. Any document or resource explaing cloudstack JUnit > implementation > > >> in greater detail would be of great help. > > >> 4. If I want to track junit of this class, how do I track and > execute > > >> them? > > >> > > >> > > >> Regards, > > >> > > >> Prakash > > >> > > > > > > > > > > > > -- > > > *Mike Tutkowski* > > > *Senior CloudStack Developer, SolidFire Inc.* > > > e: mike.tutkowski@solidfire.com > > > o: 303.746.7302 > > > Advancing the way the world uses the cloud > > > *=E2=84=A2* > > > > > > > > > > > -- > > *Mike Tutkowski* > > *Senior CloudStack Developer, SolidFire Inc.* > > e: mike.tutkowski@solidfire.com > > o: 303.746.7302 > > Advancing the way the world uses the cloud > > *=E2=84=A2* > > > > > > -- > *Mike Tutkowski* > *Senior CloudStack Developer, SolidFire Inc.* > e: mike.tutkowski@solidfire.com > o: 303.746.7302 > Advancing the way the world uses the cloud > *=E2=84=A2* > --=20 *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkowski@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud *=E2=84=A2* --001a1142f626b1dc220529bd6647--