Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: GabrielBrascher <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-672-cloudstack@git.apache.org>
In-Reply-To: <git-pr-672-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Allow VM snapshots and volume
 snapshots t...
Content-Type: text/plain
Message-Id: <20160131135352.D4390DFDC7@git1-us-west.apache.org>
Date: Sun, 31 Jan 2016 13:53:52 +0000 (UTC)

Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/672#discussion_r51360756
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java ---
    @@ -4251,6 +4257,34 @@ public void rebootVM(final Connection conn, final VM vm, final String vmName) th
             }
         }
     
    +    protected String skipOrRemoveSR(Connection conn, SR sr) {
    --- End diff --
    
    @DaanHoogland With all due respect, I don't see why a protected method can't be documented.
    
    In my point of view, private methods don't have to be documented (but may benefit from it), but protected methods might be treated as public (in terms of documenting). Even Oracle gives an example of a protected constructor with javadoc http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#defaultconstructors. In fact, at Xenserver625StorageProcessor class, this method is seen as "public".
    
    The question here should be: Is this method self-explanatory?
    I think that with respect to its act Yes. Althought it could be documented clarifying when this method skips and when it removes the SR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---