Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: rodrigo93 <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-672-cloudstack@git.apache.org>
In-Reply-To: <git-pr-672-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Allow VM snapshots and volume
 snapshots t...
Content-Type: text/plain
Message-Id: <20160131000929.462B1E00B2@git1-us-west.apache.org>
Date: Sun, 31 Jan 2016 00:09:29 +0000 (UTC)

Github user rodrigo93 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/672#discussion_r51352994
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java ---
    @@ -4251,6 +4257,34 @@ public void rebootVM(final Connection conn, final VM vm, final String vmName) th
             }
         }
     
    +    protected String skipOrRemoveSR(Connection conn, SR sr) {
    --- End diff --
    
    Hi @anshul1886 , since you are adding a new method, consider making a JavaDoc for it.
    It makes things more practicable and readable.
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---