Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D5AD51832D for ; Fri, 29 Jan 2016 20:03:43 +0000 (UTC) Received: (qmail 3025 invoked by uid 500); 29 Jan 2016 20:03:41 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 2966 invoked by uid 500); 29 Jan 2016 20:03:41 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 2498 invoked by uid 99); 29 Jan 2016 20:03:41 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jan 2016 20:03:41 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1FE87E0A12; Fri, 29 Jan 2016 20:03:41 +0000 (UTC) From: ustcweizhou To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to... Content-Type: text/plain Message-Id: <20160129200341.1FE87E0A12@git1-us-west.apache.org> Date: Fri, 29 Jan 2016 20:03:41 +0000 (UTC) Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1363#issuecomment-176945786 @alexandrelimassantana I agree with you about the code changes. However, this commit only reverts the commit 9c4162a and 16baa12 to fix the issue. The issue you mentioned does exist in our codebase, not only in these two commands, but more than 10 other commands (some are implemented in different way), you can change them in a single PR if you want. ``` [root@cloudstack(4.6)]# grep -r details.values api/src/ api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java: Collection paramsCollection = this.details.values(); api/src/org/apache/cloudstack/api/command/admin/storage/UpdateCloudToUseObjectStoreCmd.java: Collection props = details.values(); api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java: for (Map detail : details.values()) { api/src/org/apache/cloudstack/api/command/admin/storage/AddImageStoreCmd.java: Collection props = details.values(); api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java: Collection props = details.values(); api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java: Collection paramsCollection = details.values(); api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java: Collection paramsCollection = details.values(); api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java: Collection paramsCollection = details.values(); api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java: Collection paramsCollection = details.values(); api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java: Collection paramsCollection = details.values(); api/src/org/apache/cloudstack/api/command/user/template/GetUploadParamsForTemplateCmd.java: Collection paramsCollection = details.values(); api/src/org/apache/cloudstack/api/command/user/volume/AddResourceDetailCmd.java: Collection servicesCollection = details.values(); api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java: //it is because details.values() cannot be cast to a map. api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java: Collection parameterCollection = details.values(); api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java: Collection paramsCollection = this.details.values(); api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java: Collection parameterCollection = details.values(); api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java: Collection parameterCollection = details.values(); ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---