Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: DaanHoogland <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1351-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1351-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Vmdk findbugs
Content-Type: text/plain
Message-Id: <20160128120326.D214DDFFF4@git1-us-west.apache.org>
Date: Thu, 28 Jan 2016 12:03:26 +0000 (UTC)

GitHub user DaanHoogland reopened a pull request:

    https://github.com/apache/cloudstack/pull/1351

    Vmdk findbugs

    these are two of the findbugs errors coming out of our jenkins all the time. The author seems to be unavailable so I kicked and screamed at it.
    notice that this is noredist code. I did the compile without it. there is one with running.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaanHoogland/cloudstack vmdk-findbugs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1351
    
----
commit 18ba5bbf6d95e9056b981c05f88d1b914bf49cb5
Author: Daan Hoogland <daan@onecht.net>
Date:   2016-01-19T15:55:05Z

    findbugs: pre-fix reformat

commit b106f574a4828c7f45cc5711e13909fe1e6d3340
Author: Daan Hoogland <daan@onecht.net>
Date:   2016-01-19T15:56:20Z

    findbugs: use explicit encoding

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---