Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D41F018B15 for ; Wed, 20 Jan 2016 21:11:50 +0000 (UTC) Received: (qmail 91717 invoked by uid 500); 20 Jan 2016 21:11:50 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 91660 invoked by uid 500); 20 Jan 2016 21:11:50 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 91647 invoked by uid 99); 20 Jan 2016 21:11:50 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jan 2016 21:11:50 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D373CDFF93; Wed, 20 Jan 2016 21:11:49 +0000 (UTC) From: bhaisaab To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes... Content-Type: text/plain Message-Id: <20160120211149.D373CDFF93@git1-us-west.apache.org> Date: Wed, 20 Jan 2016 21:11:49 +0000 (UTC) Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1348#issuecomment-173360077 Except for the concern that there may be multiple graphics element where the method would clearly fail, LGTM. Please also squash your commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---