Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: anshul1886 <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1278-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1278-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9198: Virtual router
 gets depl...
Content-Type: text/plain
Message-Id: <20160113051509.D7BB5E185D@git1-us-west.apache.org>
Date: Wed, 13 Jan 2016 05:15:09 +0000 (UTC)

Github user anshul1886 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1278#discussion_r49552290
  
    --- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java ---
    @@ -509,7 +511,9 @@ public DomainRouterVO deployRouter(final RouterDeploymentDefinition routerDeploy
     
                 if (startRouter) {
                     try {
    -                    router = startVirtualRouter(router, _accountMgr.getSystemUser(), _accountMgr.getSystemAccount(), routerDeploymentDefinition.getParams());
    +                    final Account caller = CallContext.current().getCallingAccount();
    --- End diff --
    
    @GabrielBrascher Extracting those lines in a method will remove the contextual information from them and will impact the understanding in future so it is done this way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---