Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DA58A18719 for ; Sun, 10 Jan 2016 23:47:50 +0000 (UTC) Received: (qmail 20584 invoked by uid 500); 10 Jan 2016 23:47:50 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 20521 invoked by uid 500); 10 Jan 2016 23:47:50 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 20510 invoked by uid 99); 10 Jan 2016 23:47:50 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Jan 2016 23:47:50 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 07FF1DFFAE; Sun, 10 Jan 2016 23:47:49 +0000 (UTC) From: pedro-martins To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d... Content-Type: text/plain Message-Id: <20160110234750.07FF1DFFAE@git1-us-west.apache.org> Date: Sun, 10 Jan 2016 23:47:49 +0000 (UTC) Github user pedro-martins commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-170406819 nice =) Can you create a java doc to explain your 'isRouterDeployed()' (even the name explaining itself)? If you can create a test case for only this method it will be more easy to verify if it stop working in future modifications =) Thx. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---