cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ProjectMoon <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Refactor system VM default network creati...
Date Fri, 22 Jan 2016 10:30:12 GMT
GitHub user ProjectMoon opened a pull request:

    https://github.com/apache/cloudstack/pull/1360

    Refactor system VM default network creation

    Two small commits which moves the retrieval of the default network for the console proxy
and the SSVM into a separate protected method. It's a small change that makes the code more
readable/maintainable and also makes the class more suitable for overriding should one want
to do this. It's forward-ported from our 4.2 branch.
    
    No new tests since this should not change any functionality, and thus should be covered
by the existing unit tests.
    
    Now on the master branch (#1359 was on the wrong branch).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greenqloud/cloudstack pr-refactor-system-vm-network-creation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1360.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1360
    
----
commit 6b9c259a299ba63fa3c6a3e254dbe86285235e0c
Author: jeff <jeff@greenqloud.com>
Date:   2016-01-22T10:04:57Z

    GQSS-44: Refactor console proxy default network retrieval.
    
    It is now in a separate method for more readability and flexibility.

commit c9aeeb53e65159af511594eda04efa67e7b97a31
Author: jeff <jeff@greenqloud.com>
Date:   2016-01-22T10:07:01Z

    GQSS-44: Refactor ssvm default network retrieval.
    
    It's now in a separate method to increase readability and flexibility.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message