cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nitin-maharana <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9237: Create LB Healthcheck is...
Date Thu, 14 Jan 2016 10:40:39 GMT
GitHub user nitin-maharana opened a pull request:

    https://github.com/apache/cloudstack/pull/1340

    CLOUDSTACK-9237: Create LB Healthcheck issues - button alignment and error message goes
outside the window

    Browser - Chrome Version 47.0.2526.106 m
    
    Steps to Repro:
    ============
    Open up - Network-Guest Networks -> IP Addresses-> IP<Static NAT> -> Load
Balancing
    - click on the "Configure" button below the healthcheck, 
    - opens a "label.heath.check.wizard"
    
    Issues:
    ======
    (1) Please see the snapshot attached
    - leave the default values as is and click on the "Create" 
    - opens a "Status" dialog with an error message
    
    (2) Message on the dialog goes outside the window
    
    Fix:
    ===
    Increased the size of width of dialog box.
    Json response parsing was missing. Added it.
    
    Snapshot for Error Message Issue:
    ===========================
    ![error_message_details](https://cloud.githubusercontent.com/assets/12583725/12320920/52dbd3d0-bad1-11e5-9ce1-0fbdd2203b60.png)
    
    Snapshot of the fix:
    ===============
    <img width="627" alt="fixed_ss1_nitin" src="https://cloud.githubusercontent.com/assets/12583725/12320935/76613368-bad1-11e5-8540-cbd565edff9f.png">
    
    Snapshot for out of window issue:
    ==========================
    ![label_health_check_window](https://cloud.githubusercontent.com/assets/12583725/12320952/8f3d3062-bad1-11e5-9b85-4743d286921e.png)
    
    Snapshot of the fix:
    ===============
    <img width="695" alt="fixed_ss2_nitin" src="https://cloud.githubusercontent.com/assets/12583725/12320970/a3f7e2ae-bad1-11e5-8a9c-d2811aa6effc.png">


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nitin-maharana/CloudStack CloudStack-Nitin23_4.7

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1340.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1340
    
----
commit 49f78d18a88f8156dde1051df76496b8e5180745
Author: Nitin Kumar Maharana <nitin.maharana@gmail.com>
Date:   2016-01-14T09:53:01Z

    CLOUDSTACK-9237: Create LB Healthcheck issues - button alignment and error message goes
outside the window
    
    Increased the size of width of dialog box.
    Json response parsing was missing. Added it.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message