cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From borisroman <...@git.apache.org>
Subject [GitHub] cloudstack pull request: NicProfileHelperImpl NullpointerException...
Date Mon, 11 Jan 2016 16:24:37 GMT
GitHub user borisroman opened a pull request:

    https://github.com/apache/cloudstack/pull/1328

    NicProfileHelperImpl NullpointerException when ipVO is null

    When a VPC has a private gateway, and one would like to restart the VPC with **cleanup**
it would fail.
    
    This PR adds a NullPointer check and verifies it with an integration test.
    
    ```
    test_01_vpc_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ...
=== TestName: test_01_vpc_privategw_acl | Status : SUCCESS ===
    ok
    test_02_vpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL)
... === TestName: test_02_vpc_privategw_static_routes | Status : SUCCESS ===
    ok
    test_03_vpc_privategw_restart_vpc_cleanup (integration.smoke.test_privategw_acl.TestPrivateGwACL)
... === TestName: test_03_vpc_privategw_restart_vpc_cleanup | Status : SUCCESS ===
    ok
    test_04_rvpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL)
... === TestName: test_04_rvpc_privategw_static_routes | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 4 tests in 2945.055s
    
    OK
    ```
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/borisroman/cloudstack nullpointer_nicprofilehelperimpl

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1328.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1328
    
----
commit 78fbaf7d4da995c0cdb0ae84606e66f72c6cf289
Author: Boris Schrijver <bschrijver@schubergphilis.com>
Date:   2016-01-11T08:57:35Z

    Nullpointer Exception in NicProfileHelperImpl

commit de11b7307c2058959918ebc0eb22a55705d177b9
Author: Boris Schrijver <bschrijver@schubergphilis.com>
Date:   2016-01-11T13:34:08Z

    Add integration test for restartVPC with cleanup, and Private Gateway enabled.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message