cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ustcweizhou <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...
Date Fri, 29 Jan 2016 20:03:41 GMT
Github user ustcweizhou commented on the pull request:

    https://github.com/apache/cloudstack/pull/1363#issuecomment-176945786
  
    @alexandrelimassantana I agree with you about the code changes.
    However, this commit only reverts the commit 9c4162a and 16baa12 to fix the issue.
    
    The issue you mentioned does exist in our codebase,  not only in these two commands, but
more than 10 other commands (some are implemented in different way), you can change them in
a single PR if you want.
    
    ```
    [root@cloudstack(4.6)]# grep -r details.values api/src/
    api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java:        Collection paramsCollection
= this.details.values();
    api/src/org/apache/cloudstack/api/command/admin/storage/UpdateCloudToUseObjectStoreCmd.java:
           Collection<?> props = details.values();
    api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java:
           for (Map<String, String> detail : details.values()) {
    api/src/org/apache/cloudstack/api/command/admin/storage/AddImageStoreCmd.java:       
    Collection<?> props = details.values();
    api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java:
           Collection<?> props = details.values();
    api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java:
       Collection paramsCollection = details.values();
    api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java:       
Collection paramsCollection = details.values();
    api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java:       
Collection<String> paramsCollection = details.values();
    api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java:    
   Collection paramsCollection = details.values();
    api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java:      
 Collection paramsCollection = details.values();
    api/src/org/apache/cloudstack/api/command/user/template/GetUploadParamsForTemplateCmd.java:
       Collection paramsCollection = details.values();
    api/src/org/apache/cloudstack/api/command/user/volume/AddResourceDetailCmd.java:     
      Collection<?> servicesCollection = details.values();
    api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java:    //it is because
details.values() cannot be cast to a map.
    api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java:            Collection
parameterCollection = details.values();
    api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java:        Collection<String>
paramsCollection = this.details.values();
    api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java:            Collection
parameterCollection = details.values();
    api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java:            Collection
parameterCollection = details.values();
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message