cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.7] vmware: improve support for disk co...
Date Fri, 29 Jan 2016 17:12:40 GMT
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1365#issuecomment-176867564
  
    @GabrielBrascher Thanks for reviewing. I'm avoiding comments in the code, methods are
pretty small, self-explanatory. Tests have been added, along with the StringUtils fix. I've
deduped a class defition as well. I've deduped a class definition as well. Regarding the "_"
issue, it's a codebase wide issue. For now I'm sticking to how rest of the private vars are
named.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message