cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ProjectMoon <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Refactor system VM default network creati...
Date Fri, 29 Jan 2016 09:55:22 GMT
Github user ProjectMoon commented on the pull request:

    https://github.com/apache/cloudstack/pull/1360#issuecomment-176671839
  
    Should the three commits be squashed? Or left in three? I suggest perhaps splitting the
unit test commit into two, and putting each unit test with its corresponding refactor commit,
so the end result is two commits, each refactoring one part of system VM network selection
and providing an associated unit test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message