cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From syed <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Add ability to download templates in Swif...
Date Thu, 28 Jan 2016 17:19:45 GMT
Github user syed commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1332#discussion_r51154027
  
    --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
    @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path)
{
             command.execute(parser);
             return true;
         }
    +
    +    public static boolean setTempKey(SwiftClientCfg cfg, String tempKey){
    --- End diff --
    
    I don't think I can write a unit test for this as it relies on an external script to work
to give the correct output. I could mock the output but that would defeat the purpose of the
unit test. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message