cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...
Date Thu, 28 Jan 2016 08:37:56 GMT
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1274#issuecomment-176055926
  
    @runseb checked the diff, travis/jenkins passed, diff looked good to me.
    I've merged this and few others without integration tests as they *don't* explictly need
them; see the diff -- do you think an explicit integration test is necessary for this simple
NPE check?
    
    IMO, some changes cannot be tested by integration tests - if they are text related, in
non-Java files such as READMEs, reset scripts (not even used by systemvm/systemvm.iso). Then,
there are some changes such as this where we can cheat and avoid running integration tests
given you know the code, and build/travis passes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message