cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Quota: consolidated lockable account chec...
Date Wed, 27 Jan 2016 15:55:08 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1350#issuecomment-175702905
  
    @bhaisaab I think the test cases in different methods, each one for a single and unit
test is the right way to go.
    
    What I disagree is with the creation of “AccountVO” object. Anyone that looks at lines
202 – 204, can see that they are the same as 211- 214. Additionally, those "Id" and "DomainId"
parameters that are being set are not used by the “isLockable” method. 
    
    On top of everything, can you please look at lines 221-222, 231-232 and so forth; that
is a clear example of code duplication without even thinking.
    ```
    AccountVO accountVO = new AccountVO(); 
    accountVO = new AccountVO();
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message