cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Quota: consolidated lockable account chec...
Date Wed, 27 Jan 2016 15:39:36 GMT
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1350#issuecomment-175693496
  
    @rafaelweingartner fair points, but it would make sense if you can comment on the diff
in the context of the change.
    
    Specific to the PR I see several testXXXLockableAccount which tries to test account types
separately. Are you suggesting to get them all refactored, say put in a single testLockableAccount()
and use a single Account/User object to test the lockability instead of explicitly separate
test methods?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message