cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Quota: consolidated lockable account chec...
Date Wed, 27 Jan 2016 12:41:38 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1350#issuecomment-175599430
  
    Hi @agneya2001, there are a lot of duplicated lines at “QuotaManagerImplTest”, would
you mind removing them?
    
    Additionally, the lines you use to set the domainId and the id at the AccountVO object,
you do not need to execute them, the method that you want to test does not need them.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message