cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...
Date Mon, 25 Jan 2016 23:51:51 GMT
Github user rafaelweingartner commented on the pull request:
    @serg38, I did not know that, giving your explanation I rest my arguments ;)
    @nvazquez, you changed the method “getMountPoint” to receive a NFS protocol version,
that method uses the version in another method that is called “mount”, in which you added
a conditional to check if the version != null, then you add it to the mount command. I am
ok with that code.
    I only have a doubt, if the version may be required why aren’t you using it in most
of the code? It seems that you mostly call the “getMountPoint” method as “mountService.getMountPoint(secondaryStorageUrl,
    Actually, the only time I see you using the NFS protocol version is when you use the “prepareSecondaryStorageStore”
method. As @serg38 nicely explained that there are vendors that do not support version negotiation,
wouldn’t that be the case to always use the version that you already have in hand?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message