cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rodrigo93 <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
Date Sun, 24 Jan 2016 18:17:38 GMT
Github user rodrigo93 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1257#discussion_r50639477
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
---
    @@ -138,6 +142,8 @@
         @Inject
         private NetworkModel _netMgr;
         @Inject
    +    private HostDao _hostDao;
    --- End diff --
    
    Hi @sureshanaparti could you consider making a Jira? As a suggestion, could you remove
those underscore "_" before variables? That convention is not recommended in Java.
    Furthermore, could make a JavaDoc? That could save some time for those that are going
to read your code in the future and turns things easier and organized.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message