cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GabrielBrascher <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Refactor system VM default network creati...
Date Sat, 23 Jan 2016 18:44:26 GMT
Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1360#discussion_r50623870
  
    --- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
    @@ -666,18 +666,10 @@ public ConsoleProxyVO startNew(long dataCenterId) throws ConcurrentOperationExce
             return null;
         }
     
    -    protected Map<String, Object> createProxyInstance(long dataCenterId, VMTemplateVO
template) throws ConcurrentOperationException {
    -
    -        long id = _consoleProxyDao.getNextInSequence(Long.class, "id");
    -        String name = VirtualMachineName.getConsoleProxyName(id, _instance);
    -        DataCenterVO dc = _dcDao.findById(dataCenterId);
    -        Account systemAcct = _accountMgr.getSystemAccount();
    -
    -        DataCenterDeployment plan = new DataCenterDeployment(dataCenterId);
    -
    +    protected NetworkVO getDefaultNetworkForCreation(DataCenter dc) {
    --- End diff --
    
    @ProjectMoon Could you please create a documentation and a test case for this method ("com.cloud.consoleproxy.ConsoleProxyManagerImpl.getDefaultNetworkForCreation(DataCenter)")?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message