cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cristofolini <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Quota: consolidated lockable account chec...
Date Sat, 23 Jan 2016 18:44:25 GMT
Github user cristofolini commented on the pull request:

    https://github.com/apache/cloudstack/pull/1350#issuecomment-174211441
  
    I see you've put a bunch of different test cases into a single `testLockableAccount` method.
I'd strongly suggest you put each of those different cases into their own methods, so that
if one of them fails in a build, we can easily determine what is failing. As it stands, that
single test would fail if any of those cases goes wrong, leaving us to guess what failed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message