cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...
Date Sat, 23 Jan 2016 11:39:57 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1333#issuecomment-174176375
  
    Hi @nitin-maharana , 
    The lines from 970-1040 and lines from 1048-1118 are the same code. 
    Would you mind extracting them to a function? Then you could just call this function at
lines 970 and 1048.
    
    You have to avoid these massively duplicated blocks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message