cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From borisroman <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...
Date Wed, 20 Jan 2016 21:55:41 GMT
Github user borisroman commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1348#discussion_r50325672
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
---
    @@ -48,6 +49,9 @@
     @ResourceWrapper(handles =  MigrateCommand.class)
     public final class LibvirtMigrateCommandWrapper extends CommandWrapper<MigrateCommand,
Answer, LibvirtComputingResource> {
     
    +    private static final String CONTENTS_WILDCARD = ".*";
    +    private static final String GRAPHICS_ELEM_END = "/graphics>";
    --- End diff --
    
    This doesn't look correct... ?
    
    "<" missing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message