cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...
Date Tue, 19 Jan 2016 20:25:22 GMT
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1352#issuecomment-172975452
  
    If this helps @nislim And is tested it should go in.
    I feel uncertain of this functionality. It is called from sestro and console proxy setup
functions but the code is also present in those functions. I think the lines 1195 and 1252
should be removed and the functionality abstracted out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message